[FLINK-37076][table-planner] Support PTFs until ExecNode level#26019
Merged
twalthr merged 1 commit intoapache:masterfrom Jan 21, 2025
Merged
[FLINK-37076][table-planner] Support PTFs until ExecNode level#26019twalthr merged 1 commit intoapache:masterfrom
twalthr merged 1 commit intoapache:masterfrom
Conversation
snuyanzin
reviewed
Jan 20, 2025
...n/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalTableFunctionScan.java
Show resolved
Hide resolved
twalthr
force-pushed
the
FLINK-37076_2
branch
2 times, most recently
from
2dbf7e5 to
284ff25
Compare
snuyanzin
reviewed
Jan 20, 2025
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.table.planner.plan.nodes.physical.stream; |
Contributor
There was a problem hiding this comment.
Sorry I forgot to mention
the same issue with this class (it is in scala/* folder)
snuyanzin
reviewed
Jan 20, 2025
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.table.planner.plan.nodes.physical.stream; |
Contributor
There was a problem hiding this comment.
Sorry I forgot to mention
the same issue with this class (it is in scala/* folder)
twalthr
force-pushed
the
FLINK-37076_2
branch
from
284ff25 to
2cfe29e
Compare
Contributor
Author
|
@flinkbot run azure |
snuyanzin
approved these changes
Jan 20, 2025
Contributor
|
fyi: the failure seems to be fixed in later commits 1afe645 rebase might help |
dawidwys
approved these changes
Jan 20, 2025
twalthr
force-pushed
the
FLINK-37076_2
branch
from
2cfe29e to
170a94a
Compare
Contributor
Author
|
@flinkbot run azure |
twalthr
force-pushed
the
FLINK-37076_2
branch
from
170a94a to
22d4180
Compare
Contributor
Author
|
@flinkbot run azure |
ryanvanhuuksloot
pushed a commit
to ryanvanhuuksloot/flink
that referenced
this pull request
Feb 19, 2025
Au-Miner
pushed a commit
to Au-Miner/flink
that referenced
this pull request
Feb 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This implements a first skeleton for integrating PTFs into the planner. The PR prepares the code base for implementing a corresponding StreamExecNode.
It also prepares the CompiledPlan but concrete RestoreTests will follow.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
ProcessTableFunctionTestDoes this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation