[FLINK-37182][tests] Remove temp partition files created during test. #26025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JunRuiLee
reviewed
Jan 21, 2025
...rc/test/java/org/apache/flink/runtime/io/network/partition/PartitionedFileWriteReadTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
🤦♂️ It seems I've encountered a bug on GitHub. I merged the squashed commit, but the result was that the two commits before squashing were merged into the master. 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR improves the
PartitionedFileWriteReadTest. The test now removes partition files after it finishes.Brief change log
partitionedFile.deleteQuietly();after test finishes.Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
With the patch I confirm that the partition files are removed.
Does this pull request potentially affect one of the following parts:
This PR only contains test changes.