[hotfix] Mark Column#rename internal #26085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
afedulov
approved these changes
Jan 27, 2025
Contributor
afedulov
left a comment
afedulov
left a comment
There was a problem hiding this comment.
Do you mind checking if this makes the trick @afedulov ?
Thanks for the quick fix! For posterity:
it occurs that @PublicEvolving include for japicmp remained commented out on the release-1.20 branch which led to PRs CI passing with the violation that is not allowed for the releases (automatically gets uncommented as part of the release process)
For comparison,
1.18 branch:
Line 2286 in b2a260a
1.20 branch:
Line 2359 in 4b30669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://issues.apache.org/jira/browse/FLINK-37098?focusedCommentId=17921143&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17921143
Since I can not reproduce the original problem. Do you mind checking if this makes the trick @afedulov ?