-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-37267][table] Add support for UNNEST WITH ORDINALITY #26113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
be575db
[FLINK-37267][table] Add support for UNNEST WITH ORDINALITY
gustavodemorais 32d5725
[FLINK-37267][table] Add stream, batch and plan tests for withordinality
gustavodemorais 9972d3c
[FLINK-37267][docs] Revamp outdated unnest documentation
gustavodemorais 57137d2
[FLINK-37267][table] Support with ordinality for array/multiset of rows
gustavodemorais ef1df4c
[FLINK-37267][table] Add test for map of rows with ordinality
gustavodemorais ad7826b
[FLINK-37267][table] Simplify logic for output type with ordinality
gustavodemorais e179c09
[FLINK-37267][docs] Complement docs with multiset and map example + typo
gustavodemorais cda44cf
[FLINK-37267][table] Pass withOrdinality to base class constructors
gustavodemorais 7f522cf
[FLINK-37267][table] Refactor getFields with new RowType for naming
gustavodemorais e54bf99
[FLINK-37267][table] Refactor UnnestITCase to use parameterized calls
gustavodemorais 8d964da
[FLINK-37267][table] Use .asJava instead of HashMap
gustavodemorais 143e6ad
[FLINK-37267][table] Update unnest plans with column names
gustavodemorais 5c72d20
[FLINK-37267][table] Use JoinedRowData instead of field getters
gustavodemorais 767ac26
[FLINK-37267][table] Remove parallelism from assertUnnest
gustavodemorais 77277e0
[FLINK-37267][table] Column names to EXPR$0 and ORDINALITY
gustavodemorais File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make an example for multisets? It's not clear to me how WITH ORDINALITY behaves with them. The tests seem to drop the index?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, adding one example for multisets and one for a map. Multisets are stored as maps, so we go through the keys and emit them x amount of times, x being how often they occurred (their multiplicity).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if the example helps: e179c09