[FLINK-4773] Intoduce OperatorIOMetricGroup #2614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think this is a good refactoring. |
zentol
force-pushed
the
4773_metrics_opio
branch
from
91d84fc to
4d567d1
Compare
Contributor
Author
|
Iv'e rebased the branch and will merge it once travis passes. |
zentol
force-pushed
the
4773_metrics_opio
branch
2 times, most recently
from
e2eeefe to
e7c29db
Compare
zentol
force-pushed
the
4773_metrics_opio
branch
from
e7c29db to
9364476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the OperatorIOMetricGroup, which encapsulates the insantiation of numRecordsIn/Out counters. For clarity purposes the IOMetricGroup class was renamed to TaskIOMetricGroup.
The underlying reasoning for this change is the reuse of specific operator counters for the task (first operator numRecordsIn == task recordsIn). With this class we can more easily do this within the metric system.