Skip to content

[BP-2.0][FLINK-37301][state/forst] Fix wrong flag returned by ForStStateBackend#supportsSavepointFormat#26146

Merged
Zakelly merged 1 commit intoapache:release-2.0from
Zakelly:f37301-2.0
Feb 12, 2025
Merged

[BP-2.0][FLINK-37301][state/forst] Fix wrong flag returned by ForStStateBackend#supportsSavepointFormat#26146
Zakelly merged 1 commit intoapache:release-2.0from
Zakelly:f37301-2.0

Conversation

@Zakelly
Copy link
Contributor

@Zakelly Zakelly commented Feb 12, 2025

What is the purpose of the change

The ForStStateBackend did not override the supportsSavepointFormat, which means it gives the wrong flag. We should fix this.

Brief change log

  • Return true in supportsSavepointFormat when it is NATIVE format

Verifying this change

This change is a trivial rework, a simple test is added.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 12, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Zakelly Zakelly merged commit 7881dc3 into apache:release-2.0 Feb 12, 2025
@Zakelly Zakelly deleted the f37301-2.0 branch February 12, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants