Skip to content

Conversation

@AlexYinHan
Copy link
Contributor

What is the purpose of the change

Fix the case when ForSt encounters the first full checkpoint with IncrementalCheckpoint is enabled.

Brief change log

  • ForStIncrementalSnapshotStrategy skips throwing an exception if it encounters FORWARD sharingFilesStrategy but there are no previous snapshots to reuse.

Verifying this change

This change added tests and can be verified as follows:

  • ForStIncrementalSnapshotStrategyTest#testIncrementalCheckpointWithFirstBeingFull

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 19, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zakelly Zakelly merged commit b2a02f9 into apache:release-2.0 Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants