[hotfix] Fix post-release japicmp update script for macOS#26182
Merged
Conversation
afedulov
changed the title
Mac uses BSD sed that requires an explicit extension for -i option. This works universally for both GNU and BSD sed.
afedulov
force-pushed
the
release-1.19-sed
branch
from
90fcdf1 to
c978906
Compare
Collaborator
mbalassi
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mac uses BSD sed that requires an explicit extension for
-ioption. This works universally for both GNU and BSD sed.I believe it previously caused issues with
@PublicEvolvingjavacmp exclusions not being correctly removed after the release which led to incompatible changes being merged. Without the fix, the pom file gets modified incompletely, with an error message that is easy to misssed: 1: "../pom.xml": invalid command code .Note: to reproduce current erroneous behavior, put a couple of lines between the
MARKER:comments in pom.xml