Skip to content

Conversation

@snuyanzin
Copy link
Contributor

What is the purpose of the change

There was a fix on frontend-maven-plugin eirslett/frontend-maven-plugin@e2d0445
which should help with corrupted file issue FLINK-30719

Brief change log

pom.xml

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes )
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no )
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
  • The S3 file system connector: ( no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable )

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 23, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin
Copy link
Contributor Author

@reswqa , @leonardBang can you have a look here please
since you also were involved FLINK-30719

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @snuyanzin for the fix, LGTM

Minor proposal for commit message:
[FLINK-30719][web] Update frontend-maven-plugin from 1.12.1 to 1.15.1 to make sure download files fully before write to disk

@snuyanzin snuyanzin force-pushed the flink30719 branch 2 times, most recently from 3225ffa to 742af11 Compare February 24, 2025 11:41
@snuyanzin
Copy link
Contributor Author

snuyanzin commented Feb 24, 2025

Failure is related to FLINK-37373
to double check it I added a revert commit for the one which was a reason of failure (there is a separate PR for that which I'm going to merge first in case of success)
#26198

… to make sure download files fully before write to disk
@snuyanzin snuyanzin merged commit 835c64b into apache:master Feb 24, 2025
@snuyanzin snuyanzin deleted the flink30719 branch July 29, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants