Skip to content

Conversation

@lincoln-lil
Copy link
Contributor

What is the purpose of the change

Currently under the stream mode when an global agg with filter arg which actually references the first input column, then the corresponding agg column result will be incorrect(this issue doesn't exist in batch mode).

Brief change log

Add new agg cases

Verifying this change

AggregateITCase

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @public(Evolving): (no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 14, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@xuyangzhong xuyangzhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for driving this. LGTM. Waiting for CI to pass.

@lincoln-lil lincoln-lil merged commit 3891fe8 into apache:master Mar 17, 2025
@lincoln-lil lincoln-lil deleted the FLINK-30687 branch March 17, 2025 06:46
lincoln-lil added a commit to lincoln-lil/flink that referenced this pull request Mar 17, 2025
lincoln-lil added a commit to lincoln-lil/flink that referenced this pull request Mar 17, 2025
jklaw90 pushed a commit to jklaw90/flink that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants