Skip to content

Conversation

@beliefer
Copy link
Contributor

What is the purpose of the change

This PR aims to rename JobRestEndpointFactory to ApplicationRestEndpointFactory.
AFAIK, Flink already removed Job-Cluster or renamed it with Application-Cluster. There are many classes renamed from Job* to Application*. I guess we missing the JobRestEndpointFactory.

Brief change log

Rename JobRestEndpointFactory to ApplicationRestEndpointFactory.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 25, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@beliefer
Copy link
Contributor Author

Copy link
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM

@1996fanrui 1996fanrui merged commit 36111ca into apache:master Mar 26, 2025
@beliefer
Copy link
Contributor Author

@1996fanrui Thank you very much !

jklaw90 pushed a commit to jklaw90/flink that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants