[FLINK-37856] Ensure sink option hints are present in compiled plan [2.0]#26621
Merged
Conversation
compilePlan and executeSql use two different code paths. The former uses DynamicTableSinkSpec to render the json, the latter directly creates the DynamicSinkTable. Merging the dynamic options so far only happened on the second code path. This commit eagerly merges the options into the ResolvedCatalogTable such that the combined options can be used in both code paths. The commit still retains all hints fields and parameters to ensure that explain still outputs the same plan where hints are explicitly added if available. The hints are not explicitly used while creating the DynamicSinkTable anymore because the ResolvedCatalogTable already contains them.
Collaborator
snuyanzin
approved these changes
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unchanged backport of #26601