[Flink-37703][UnitTest]The testRecoverFromIntermWithoutAdditionalState test failed of azure cron connector pipeline #26633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes
…NK on YARN's File Creation to Manage Disk Space and Network Load in Labeled YARN Nodes
…cron connector pipeline
Contributor
Author
|
@lsyldliu is this pr OK? |
lsyldliu
reviewed
Jun 5, 2025
Contributor
lsyldliu
left a comment
lsyldliu
left a comment
There was a problem hiding this comment.
@liangyu-1 Thanks for your contribution, I left some comments.
| recoverables.put(INIT_EMPTY_PERSIST, stream.persist()); | ||
| } catch (IOException e) { | ||
| System.err.println("Unable to open file for writing " + path.toString()); | ||
| throw e; |
Contributor
There was a problem hiding this comment.
Apr 28 12:19:16 java.io.IOException: All datanodes [DatanodeInfoWithStorage[127.0.0.1:46278,DS-26d47d25-42de-4eef-a409-8a700a8bc82a,DISK]] are bad. Aborting...
Apr 28 12:19:16 at org.apache.hadoop.hdfs.DataStreamer.handleBadDatanode(DataStreamer.java:1537)
Apr 28 12:19:16 at org.apache.hadoop.hdfs.DataStreamer.setupPipelineForAppendOrRecovery(DataStreamer.java:1472)
Apr 28 12:19:16 at org.apache.hadoop.hdfs.DataStreamer.processDatanodeError(DataStreamer.java:1244)
Apr 28 12:19:16 at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:663)
Based on the original error message, we need to locate why the HDFS DataNode node is broken, can throwing an exception on the client side find the root cause? I don't know much about HDFS, so I'm not sure. Do we need to turn on the logging on the Server side when we pull up the HDFS cluster and observe the behavior on the Server side?
| try { | ||
| stream.write(testData1.getBytes(StandardCharsets.UTF_8)); | ||
| } catch (IOException e) { | ||
| System.err.println("Initial write failed: " + e.getMessage()); |
Contributor
There was a problem hiding this comment.
Can you use LOG.info to print the message?
| recoverables.put(INIT_EMPTY_PERSIST, stream.persist()); | ||
|
|
||
| stream.write(testData1.getBytes(StandardCharsets.UTF_8)); | ||
| try { |
Contributor
There was a problem hiding this comment.
I think we should simplify the print log logic, only print it the catch block as following:
// This is just for locate the root cause:
// https://issues.apache.org/jira/browse/FLINK-37703
// After the fix, this logic should be reverted.
int branch = 0;
try {
branch++;
stream = initWriter.open(path);
branch++;
recoverables.put(INIT_EMPTY_PERSIST, stream.persist());
branch++;
stream.write(testData1.getBytes(StandardCharsets.UTF_8));
branch++;
recoverables.put(INTERM_WITH_STATE_PERSIST, stream.persist());
branch++;
recoverables.put(INTERM_WITH_NO_ADDITIONAL_STATE_PERSIST, stream.persist());
// and write some more data
branch++;
stream.write(testData2.getBytes(StandardCharsets.UTF_8));
branch++;
recoverables.put(FINAL_WITH_EXTRA_STATE, stream.persist());
} catch (IOException e) {
LOG.info(
"The exception branch was: {}, detail exception msg: {}",
branch,
e.getMessage());
throw e;
} finally {
|
|
||
| recoveredStream.write(testData3.getBytes(StandardCharsets.UTF_8)); | ||
| recoveredStream.closeForCommit().commit(); | ||
| try { |
lsyldliu
reviewed
Jun 6, 2025
| */ | ||
| public abstract class AbstractRecoverableWriterTest { | ||
|
|
||
| private static final Logger Log = LoggerFactory.getLogger(AbstractRecoverableWriterTest.class); |
Contributor
There was a problem hiding this comment.
Suggested change
| private static final Logger Log = LoggerFactory.getLogger(AbstractRecoverableWriterTest.class); | |
| private static final Logger LOG = LoggerFactory.getLogger(AbstractRecoverableWriterTest.class); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR is to find out what makes the hadoop-fs UT unstable.
Brief change log
AbstractRecoverableWriterTest.javaVerifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation