Skip to content

[FLINK-4866] [streaming] Make Trigger.clear() Abstract to Enforce Implementation#2672

Closed
wuchong wants to merge 1 commit into
apache:masterfrom
wuchong:trigger-FLINK-4866
Closed

[FLINK-4866] [streaming] Make Trigger.clear() Abstract to Enforce Implementation#2672
wuchong wants to merge 1 commit into
apache:masterfrom
wuchong:trigger-FLINK-4866

Conversation

@wuchong
Copy link
Copy Markdown
Member

@wuchong wuchong commented Oct 21, 2016

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General
    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation
    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build
    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

This PR makes Trigger.clear() method to be abstract, so that implementors of custom triggers will not forget to clean up their state/timers properly.

@aljoscha
Copy link
Copy Markdown
Contributor

Thanks for your work. 👍 I'll be merging this tomorrow.

@aljoscha
Copy link
Copy Markdown
Contributor

I merged this. Could you please close the issue?

@wuchong
Copy link
Copy Markdown
Member Author

wuchong commented Oct 24, 2016

Sure. I will close this.

@wuchong wuchong closed this Oct 24, 2016
@wuchong wuchong deleted the trigger-FLINK-4866 branch May 15, 2017 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants