[FLINK-37701][flink-runtime] Backporting of the fix to 2.0 for AdaptiveScheduler ignoring checkpoint states sizes for local recovery adjustment.#26796
Merged
Conversation
Collaborator
rkhachatryan
approved these changes
Jul 14, 2025
Contributor
rkhachatryan
left a comment
There was a problem hiding this comment.
LGTM assuming CI is green
1996fanrui
approved these changes
Jul 15, 2025
Member
1996fanrui
left a comment
There was a problem hiding this comment.
Thanks for the backporting, CI is green, merging
Contributor
Author
|
Thank you Rui |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously merged PRs:
PR1 #26663
What is the purpose of the change
Address local recovery issues when Adaptive scheduler is enabled.
StateSizeEstimates(that is needed because execution graph goes through cancelling/cancelled state and checkpoint coordinator isnulledby the time we run calculations).managedKeyedStateis present, but local recovery semantics doesn'trequirestate presence).Context: When job can be recovered locally, we should keep slot allocation after restart to maintain
Verifying this change
LocalRecoveryITCase#testRecoverLocallyFromProcessCrashWithWorkingDirectorynow passes whenAdaptiveScheduleris enabled.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation
PR2 #26712
Brief change log
AdaptiveSchedulerTestintoAdaptiveSchedulerTestBase.AdaptiveSchedulerTestBase.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation