Skip to content

Conversation

@davidradl
Copy link
Contributor

What is the purpose of the change

Add logging so we can see more information about the cause of the test failure reported in FLINK-38536

Brief change log

  • add logging to test

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

*amended existing unit test to add logging

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: ( no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Signed-off-by: davidradl <david_radley@uk.ibm.com>
@flinkbot
Copy link
Collaborator

flinkbot commented Oct 29, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Signed-off-by: davidradl <david_radley@uk.ibm.com>
@davidradl davidradl marked this pull request as draft October 29, 2025 15:43
@davidradl
Copy link
Contributor Author

@flinkbot run azure

@davidradl davidradl marked this pull request as ready for review October 30, 2025 09:21
@davidradl davidradl closed this Oct 30, 2025
@davidradl davidradl reopened this Oct 30, 2025
@davidradl davidradl changed the title [FLINK-38536] Add debugging for test failure [FLINK-38536][Tests] Add debugging for test failure Oct 30, 2025
@davidradl davidradl changed the title [FLINK-38536][Tests] Add debugging for test failure [FLINK-38536][tests] Add debugging for test failure Oct 30, 2025
@ruanhang1993
Copy link
Contributor

LGTM. @davidradl We need to rebase the master branch to let the tests pass.

@davidradl
Copy link
Contributor Author

@ruanhang1993 No conflicts with base indicates it can merge; so no need to rebase. I did git pull upstream master --rebase there is nothing to push. The error on the CI seems to be an unrelated Python error - another CI test instability issue I think.

@ruanhang1993
Copy link
Contributor

This PR just add some logs to debug. Merge.

@ruanhang1993 ruanhang1993 merged commit 4783610 into apache:master Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants