Skip to content

[FLINK-37427] Fix NPE in StandaloneHaServices and add unit testAdd unit test case for StandaloneHaServices constructor #27258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[FLINK-37427] Fix NPE in StandaloneHaServices and add unit testAdd unit test case for StandaloneHaServices constructor #27258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfd5ca1
Add unit test case for StandaloneHaServices constructor
lurongjiang Nov 20, 2025
0b88647
apply spotless format
lurongjiang Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...java/org/apache/flink/runtime/highavailability/nonha/standalone/StandaloneHaServices.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public StandaloneHaServices(
checkNotNull(resourceManagerAddress, "resourceManagerAddress");
this.dispatcherAddress = checkNotNull(dispatcherAddress, "dispatcherAddress");
this.clusterRestEndpointAddress =
checkNotNull(clusterRestEndpointAddress, clusterRestEndpointAddress);
checkNotNull(clusterRestEndpointAddress, "clusterRestEndpointAddress");
}

// ------------------------------------------------------------------------
Expand Down
34 changes: 34 additions & 0 deletions .../org/apache/flink/runtime/highavailability/nonha/standalone/StandaloneHaServicesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
import org.junit.Before;
import org.junit.Test;

import static org.junit.Assert.assertThrows;
import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
Expand Down Expand Up @@ -141,4 +143,36 @@ public void testJobMasterLeaderRetrieval() throws Exception {
.notifyLeaderAddress(
eq(jobManagerAddress2), eq(HighAvailabilityServices.DEFAULT_LEADER_ID));
}

/**
* Tests that the constructor properly validates null parameters and provides meaningful error
* messages.
*/
@Test
public void testConstructorNullValidation() {
// Test null resourceManagerAddress
Exception exception =
assertThrows(
NullPointerException.class,
() -> new StandaloneHaServices(null, dispatcherAddress, webMonitorAddress));
assertTrue(exception.getMessage().contains("resourceManagerAddress"));

// Test null dispatcherAddress
exception =
assertThrows(
NullPointerException.class,
() ->
new StandaloneHaServices(
resourceManagerAddress, null, webMonitorAddress));
assertTrue(exception.getMessage().contains("dispatcherAddress"));

// Test null clusterRestEndpointAddress
exception =
assertThrows(
NullPointerException.class,
() ->
new StandaloneHaServices(
resourceManagerAddress, dispatcherAddress, null));
assertTrue(exception.getMessage().contains("clusterRestEndpointAddress"));
}
}