Skip to content

Conversation

@dianfu
Copy link
Contributor

@dianfu dianfu commented Nov 21, 2025

What is the purpose of the change

This PR fixes the following issue:

For the following query:

SELECT func1(e.f.h) from MyTable

where the schema of MyTable is as following:

CREATE TABLE MyTable (
    a int,
    b bigint,
    c string,
    d ARRAY<INT NOT NULL>,
    e ROW<f ROW<h int, i double>, g string>
) WITH (
    'connector' = 'test-simple-table-source'
)

The following exception will be thrown:

java.lang.AssertionError: RexInputRef index 5 out of range 0..4
	at org.apache.calcite.rex.RexProgramBuilder$RegisterInputShuttle.visitInputRef(RexProgramBuilder.java:947)
	at org.apache.calcite.rex.RexProgramBuilder$RegisterInputShuttle.visitInputRef(RexProgramBuilder.java:932)
	at org.apache.calcite.rex.RexInputRef.accept(RexInputRef.java:125)
	at org.apache.calcite.rex.RexShuttle.visitFieldAccess(RexShuttle.java:203)
	at org.apache.calcite.rex.RexProgramBuilder$RegisterShuttle.visitFieldAccess(RexProgramBuilder.java:912)
	at org.apache.calcite.rex.RexProgramBuilder$RegisterShuttle.visitFieldAccess(RexProgramBuilder.java:895)
	at org.apache.calcite.rex.RexFieldAccess.accept(RexFieldAccess.java:94)
	at org.apache.calcite.rex.RexProgramBuilder.registerInput(RexProgramBuilder.java:303)
	at org.apache.calcite.rex.RexProgramBuilder.addProject(RexProgramBuilder.java:213)
	at org.apache.calcite.rex.RexProgram.create(RexProgram.java:235)
	at org.apache.flink.table.planner.plan.rules.logical.RemoteCalcSplitRuleBase.onMatch(RemoteCalcSplitRule.scala:111)

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 21, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

…onFunction & AsyncFunction work when taking the recursive field of composite type as input
@dianfu dianfu force-pushed the fix_complex_field_access branch from 3f1b403 to d8a8b31 Compare November 24, 2025 01:29
Copy link
Contributor

@bgeng777 bgeng777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Nov 24, 2025
@dianfu dianfu closed this in b152cde Nov 24, 2025
dianfu added a commit that referenced this pull request Nov 24, 2025
…onFunction & AsyncFunction work when taking the recursive field of composite type as input

This closes #27259.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants