[FLINK-1325] [streaming] Added clousure cleaning to streaming#273
Closed
mbalassi wants to merge 1 commit intoapache:masterfrom
Closed
[FLINK-1325] [streaming] Added clousure cleaning to streaming#273mbalassi wants to merge 1 commit intoapache:masterfrom
mbalassi wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
We don't need the extra cleaning before the .getClass() method. This also applied to the other parts in this PR where that pattern occurs.
Contributor
|
Code looks good, other than the remark I had about cleaning the user function for type extraction (which is unnecessary). |
mbalassi
force-pushed
the
closclean
branch
2 times, most recently
from
1689b33 to
3107229
Compare
Contributor
Author
|
Thanks spotting it, updated accordingly. |
mbalassi
added a commit
to mbalassi/flink
that referenced
this pull request
Dec 17, 2014
asfgit
pushed a commit
that referenced
this pull request
Dec 17, 2014
mbalassi
added a commit
to mbalassi/flink
that referenced
this pull request
Dec 18, 2014
zhijiangW
pushed a commit
to zhijiangW/flink
that referenced
this pull request
Apr 13, 2020
This closes apache#273.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streaming update for @aljoscha's recent PR.
The functionality is there, the code could be a bit nicer but as @gyfora has already refactored the builder methods in the DataStream for the streaming scala-api and not yet merged it this solution will be more straightforward to merge.
As this is part of the recently merged PR @aljoscha and myself are personally for adding it to the 0.8 release (with this codebase, not the merged one).