-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-38939][runtime] Pause sources until the 1st checkpoint to prioritize processing recovered records #27440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…eived This allows to prioritize processing of recovered records (when recovering from an unaligned checkpoint)
…g for a checkpoint
| <td><h5>pipeline.sources.pause-until-first-checkpoint</h5></td> | ||
| <td style="word-wrap: break-word;">true</td> | ||
| <td>Boolean</td> | ||
| <td>Don't pull any data from sources until the first checkpoint is triggered. This might be helpful in reducing recovery times. Incompatible 0 value for execution.checkpointing.interval-during-backlog</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest expanding on "This might be helpful in reducing recovery times." to be specific about the scenarios that this would be helpful in. Are there scenarios it would not be helpful in? If there are no downsides to this change - then do we need a config option?
I am not sure what Incompatible 0 value for execution.checkpointing.interval-during-backlog means .
| && checkpointConfig.isPauseSourcesUntilFirstCheckpoint()) { | ||
| throw new IllegalArgumentException( | ||
| "Pausing sources until first checkpoint is incompatible with disabling checkpoints during backlog processing. " | ||
| + "Please consult " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "Please consult ...." -> "Please review and choose whether you require + CheckpointingOptions.PAUSE_SOURCES_UNTIL_FIRST_CHECKPOINT.key()
+ " or"
+ CheckpointingOptions.CHECKPOINTING_INTERVAL_DURING_BACKLOG.key());
No description provided.