[optimize] Add isWarnEnabled guard for expensive log construction#27522
Open
dingqianwen wants to merge 1 commit intoapache:masterfrom
Open
[optimize] Add isWarnEnabled guard for expensive log construction#27522dingqianwen wants to merge 1 commit intoapache:masterfrom
dingqianwen wants to merge 1 commit intoapache:masterfrom
Conversation
Avoids expensive string formatting and array-to-string conversion in `LOG.warn` when the logging level is not enabled. This improves performance by skipping the argument construction for the file splitting log message.
Collaborator
davidradl
approved these changes
Feb 4, 2026
github-actions
bot
added
the
community-reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids expensive string formatting and array-to-string conversion in
LOG.warnwhen the logging level is not enabled. This improves performance by skipping the argument construction for the file splitting log message.