[FLINK-5021] Makes the ContinuousFileReaderOperator rescalable.#2763
Closed
kl0u wants to merge 4 commits intoapache:masterfrom
Closed
[FLINK-5021] Makes the ContinuousFileReaderOperator rescalable.#2763kl0u wants to merge 4 commits intoapache:masterfrom
kl0u wants to merge 4 commits intoapache:masterfrom
Conversation
kl0u
force-pushed
the
repart_fs
branch
2 times, most recently
from
2afb9cd to
5f51f4e
Compare
Without this special split signaling that no more splits are to arrive, the ContinuousFileReaderOperator now closes by setting a flag that marks it as closed and exiting when the flag is set to true and the pending split queue is empty.
This is the last commit that completes the refactoring of the ContinuousFileReaderOperator so that it can be rescalable. With this, the reader can restart from a savepoint with a different parallelism without compromising the provided exactly-once guarantees.
Contributor
|
I merged this, thanks for your work! 👍 Could you please close this PR and the Jira issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last PR that completes the refactoring of the
ContinuousFileReaderOperatorso that it can be rescalable. With this, the reader can restart from a savepoint with a different parallelism without compromising the provided exactly-once guarantees.The whole PR contains 3 commits.
The first removes the EOS special split which was used to signal that no new splits are to be processed. This was useful in the
PROCESS_ONCEmode. Now the reader closes by setting a flag and waiting for all the pending splits to be fully processed.The second puts an additional check in the
ContinuousFileMonitoringFunctionthat guarantees that in the case of thePROCESS_ONCE, the source will not reprocess the directory after recovering from a failure.Finally, the third integrates the new rescalable state abstractions with the reader so that the reader can restart from a savepoint with different parallelism and still guarantee exactly-once semantics.
R: @aljoscha