[FLINK-39124] Update flink-tests to JUnit5#27657
Open
mateczagany wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-39124] Update flink-tests to JUnit5#27657mateczagany wants to merge 1 commit intoapache:masterfrom
mateczagany wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
RocMarshal
requested changes
Feb 24, 2026
Contributor
RocMarshal
left a comment
RocMarshal
left a comment
There was a problem hiding this comment.
Thanks @mateczagany for the big patch!
I've briefly reviewed and flagged a few representative examples of issues.
Please take a look when you have time.
Also, the current change set might contain too many lines of modifications. It would be helpful for review progress and quality if you could split the PR or commits into categories or thematic groups.
| /** An integration test for rate limiting built into the DataGeneratorSource. */ | ||
| public class RateLimitedSourceReaderITCase extends TestLogger { | ||
| @ExtendWith(TestLoggerExtension.class) | ||
| public class RateLimitedSourceReaderITCase { |
Contributor
There was a problem hiding this comment.
Could the public be deleted ?
| try (CloseableIterator<Long> sumsIterator = sums.executeAndCollect()) { | ||
| List<Long> results = CollectionUtil.iteratorToList(sumsIterator); | ||
| assertThat(results, equalTo(Arrays.asList(30L, 25L))); | ||
| assertThat(results).isEqualTo(Arrays.asList(30L, 25L)); |
Comment on lines
+139
to
+140
| assertEquals(2, collectSinkOperatorFactory.getSocketTimeoutMillis()); | ||
| assertEquals(3, collectSinkFunction.getMaxBytesPerBatch()); |
Contributor
There was a problem hiding this comment.
It would be better if use assertThat.
|
|
||
| @Test | ||
| public void testInvalidTypeAccumulator() throws Exception { | ||
| public void testInvalidTypeAccumulator() { |
Contributor
There was a problem hiding this comment.
Suggested change
| public void testInvalidTypeAccumulator() { | |
| void testInvalidTypeAccumulator() { |
Contributor
Author
|
Thank you very much for your review @RocMarshal - I will open other, smaller PRs with the suggested changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Migrate all tests in module flink-tests from JUnit4 to JUnit5.
Brief change log
@SuppressWarningswhere it was unnecessaryVerifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation