[FLINK-39157][table-common] Add ColumnList.hashCode()/equals()#27674
Merged
twalthr merged 3 commits intoapache:masterfrom Mar 2, 2026
Merged
[FLINK-39157][table-common] Add ColumnList.hashCode()/equals()#27674twalthr merged 3 commits intoapache:masterfrom
twalthr merged 3 commits intoapache:masterfrom
Conversation
snuyanzin
reviewed
Feb 25, 2026
flink-table/flink-table-common/src/test/java/org/apache/flink/types/ColumnListTest.java
Outdated
Show resolved
Hide resolved
snuyanzin
reviewed
Feb 25, 2026
flink-table/flink-table-common/src/test/java/org/apache/flink/types/ColumnListTest.java
Outdated
Show resolved
Hide resolved
snuyanzin
reviewed
Feb 25, 2026
| private ColumnList(List<String> names, List<DataType> dataTypes) { | ||
| this.names = Preconditions.checkNotNull(names, "Names must not be null."); | ||
| this.dataTypes = Preconditions.checkNotNull(dataTypes, "Data types must be null."); | ||
| Preconditions.checkNotNull(names, "Names must not be null."); |
Contributor
There was a problem hiding this comment.
should we have a check here that all names are unique?
Contributor
Author
There was a problem hiding this comment.
This is not a requirement for DESCRIPTOR as far as I know
Collaborator
snuyanzin
approved these changes
Feb 25, 2026
snuyanzin
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Improves the quality of
ColumnList.Brief change log
Verifying this change
This change added tests and can be verified as follows:
ColumnListTestDoes this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation