[FLINK-39326][runtime] Fix DispatcherApplicationTest.testJobResultNot…#27830
Open
eemario wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-39326][runtime] Fix DispatcherApplicationTest.testJobResultNot…#27830eemario wants to merge 1 commit intoapache:masterfrom
eemario wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
…MarkedCleanUntilApplicationTerminates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…MarkedCleanUntilApplicationTerminates
What is the purpose of the change
This pull request addresses a flaky test: DispatcherApplicationTest.testJobResultNotMarkedCleanUntilApplicationTerminates.
The test occasionally fails because the assertion that a dirty job result exists may run before the job result is actually created.
To resolve this, the test has been updated to wait for the job result to be created before performing the subsequent validation.
Brief change log
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
This change is already covered by existing tests, such as DispatcherApplicationTest.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation