Skip to content

[FLINK-39309][runtime] Check terminated applications for duplication#27834

Merged
zhuzhurk merged 2 commits intoapache:masterfrom
eemario:terminated-app
Apr 1, 2026
Merged

[FLINK-39309][runtime] Check terminated applications for duplication#27834
zhuzhurk merged 2 commits intoapache:masterfrom
eemario:terminated-app

Conversation

@eemario
Copy link
Copy Markdown
Contributor

@eemario eemario commented Mar 26, 2026

What is the purpose of the change

This pull request fixes a missing validation that prevented the detection of duplicate terminated applications during submission and recovery.

Brief change log

  • Implement duplicate detection for terminated applications during submission.
  • Automatically shut down the cluster in Application Mode if the target application is already terminated.

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

This change added tests and can be verified as follows:

  • Added tests in DispatcherApplicationTest that verify duplicate detection logic for terminated applications
  • Added test coverage for utility methods in ApplicationResultStore and ApplicationStatus
  • Manually verified the change by running a standalone cluster, re-submitting an application with an ID matching a terminated one and confirming that the expected exception is thrown

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Mar 26, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@eemario eemario force-pushed the terminated-app branch 2 times, most recently from 6f563b9 to 8793872 Compare March 27, 2026 08:13
@eemario eemario marked this pull request as ready for review March 27, 2026 08:31
Copy link
Copy Markdown
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhuzhurk zhuzhurk merged commit 923a359 into apache:master Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants