[FLINK-39479][python] Add fromChangelog() to Python Table API#27975
[FLINK-39479][python] Add fromChangelog() to Python Table API#27975twalthr merged 2 commits intoapache:masterfrom
Conversation
| """ | ||
| return Table(self._j_table.toChangelog(to_expression_jarray(arguments)), self._t_env) | ||
|
|
||
| def from_changelog(self, *arguments: Expression) -> 'Table': |
There was a problem hiding this comment.
Currently, both the from_changelog and to_changelog lack corresponding Python side tests, and have even been enlarged to include insert_into and print_explain in the entire table.py. I think we can create a Jira to fill in this part of the testing.
There was a problem hiding this comment.
Make sense. Overall Python is only forwarding to Java, so we did not always adds tests for the conversion. If the file syntactically compiles there is a high chance that also a test should pass.
There was a problem hiding this comment.
@Au-Miner Thanks for pointing this out. Added a new ticket so we can track this: https://issues.apache.org/jira/browse/FLINK-39505
gustavodemorais
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback, @raminqaf. LGTM
What is the purpose of the change
The Python Table API is missing the Table.fromChangelog() method introduced with the changelog PTFs (FLIP-564).
Brief change log
- Add from_changelog() to pyflink/table/table.py
- Remove fromChangelog from completeness test exclusions
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes)Documentation
Was generative AI tooling used to co-author this PR?