[FLINK-39527][test] Migrate flink-end-to-end-tests to JUnit 5#28040
Open
mateczagany wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-39527][test] Migrate flink-end-to-end-tests to JUnit 5#28040mateczagany wants to merge 1 commit intoapache:masterfrom
mateczagany wants to merge 1 commit intoapache:masterfrom
Conversation
mateczagany
force-pushed
the
FLINK-39527
branch
from
6bfdefb to
78e9cc5
Compare
Collaborator
RocMarshal
reviewed
Apr 29, 2026
Contributor
There was a problem hiding this comment.
Thank you @mateczagany for your contribution.
LGTM +1 on the whole, just a few of comments.
PTAL~
Comment on lines
+34
to
+40
| void before() throws Exception; | ||
|
|
||
| void afterTestSuccess(); | ||
|
|
||
| default void afterTestFailure() { | ||
| afterTestSuccess(); | ||
| } |
Contributor
There was a problem hiding this comment.
Could you help add some comment lines to describe the methods definetion ?
Comment on lines
+34
to
+40
| void before() throws Exception; | ||
|
|
||
| void afterTestSuccess(); | ||
|
|
||
| default void afterTestFailure() { | ||
| afterTestSuccess(); | ||
| } |
davidradl
reviewed
May 5, 2026
|
|
||
| @Rule public final DownloadCache downloadCache = DownloadCache.get(); | ||
| @RegisterExtension | ||
| private final DownloadCacheExtension downloadCache = |
Contributor
There was a problem hiding this comment.
I suggest the variable name is downloadCacheExtension. Leaving as downloadCache is confusing.
Also if we are now using the Extension, can we make DownloadCache private to the DownloadCacheExtension, so no-one can use it apart from via the extension?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Update flink-end-to-end-tests module to use only JUnit 5 instead of JUnit 4
Brief change log
FlinkResourceExtensionandDownloadCacheExtensionVerifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?