[FLINK-39598][table] Update jline to 3.30.12#28099
Merged
Merged
Conversation
snuyanzin
commented
May 3, 2026
Comment on lines
218
to
+327
| @@ -317,6 +317,15 @@ private void closeTerminal() { | |||
| } | |||
| } | |||
|
|
|||
| private static String newLinePrompt(Terminal terminal) { | |||
| return new AttributedStringBuilder() | |||
| .style(AttributedStyle.DEFAULT.foreground(AttributedStyle.GREEN)) | |||
| .append("Flink SQL") | |||
| .style(AttributedStyle.DEFAULT) | |||
| .append("> ") | |||
| .toAnsi(terminal); | |||
| } | |||
Contributor
Author
There was a problem hiding this comment.
in 3.30 in dumbterminal it was introduced password support
so need to work around it jline/jline3#1205
Collaborator
Contributor
Author
|
cc @spuru9 since you asked about 3.30.x |
spuru9
approved these changes
May 3, 2026
Contributor
spuru9
left a comment
spuru9
left a comment
There was a problem hiding this comment.
LGTM. A minor suggestion.
| <groupId>org.jline</groupId> | ||
| <artifactId>jline-terminal</artifactId> | ||
| <version>3.29.0</version> | ||
| <version>3.30.12</version> |
Contributor
There was a problem hiding this comment.
Not introduced in this PR as such. But we would be having the same version for terminal and reader, would look better to introduce a variable to not lead to a future conflict on dependencies. Non blocking.
github-actions
Bot
added
the
community-reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The PR to bump jline to 3.30.12
Brief change log
pom, NOTICE
Verifying this change
existing tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?