Skip to content

[FLINK-39641][runtime-web] Fix unstable position of the Rescales Tab#28131

Merged
RocMarshal merged 1 commit intoapache:masterfrom
RocMarshal:FLINK-39641
May 9, 2026
Merged

[FLINK-39641][runtime-web] Fix unstable position of the Rescales Tab#28131
RocMarshal merged 1 commit intoapache:masterfrom
RocMarshal:FLINK-39641

Conversation

@RocMarshal
Copy link
Copy Markdown
Contributor

@RocMarshal RocMarshal commented May 9, 2026

What is the purpose of the change

[FLINK-39641][runtime-web] Fix unstable position of the Rescales Tab

Brief change log

  • Fix the target position of Rescales finding logic

Verifying this change

  • Before the fix:
image
  • After the fix:
image

I followed the reproduction steps[1] and tried 10 times, the issue no longer occurred.
[1] https://issues.apache.org/jira/browse/FLINK-39494

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 9, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@spuru9 spuru9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RocMarshal Can you add the before and after image to the PR?

@RocMarshal
Copy link
Copy Markdown
Contributor Author

Thanks @spuru9 for your reminder.
I added the images.

PTAL.

@spuru9
Copy link
Copy Markdown
Contributor

spuru9 commented May 9, 2026

Thanks @spuru9 for your reminder. I added the images.

PTAL.

I saw a similar fix in #28044, Is this something different?

@RocMarshal
Copy link
Copy Markdown
Contributor Author

HI, @spuru9 It seems that the fix you mentioned does not fully resolve the current issue, which is part of the reason why this PR is needed.

@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label May 9, 2026
@RocMarshal RocMarshal self-assigned this May 9, 2026
@RocMarshal RocMarshal requested a review from spuru9 May 9, 2026 10:00
@och5351
Copy link
Copy Markdown
Contributor

och5351 commented May 9, 2026

Hi, @spuru9 !

These are actually two different issues. The previous one: when the adaptive scheduler was enabled, after viewing a batch job screen (where the Rescales tab didn't exist) and then navigating to a streaming job overview, the tab order would shift unexpectedly.

The current one: when a cluster without the adaptive scheduler is restarted with it enabled, viewing the job in the same browser tab shows incorrect tab order—but refreshing the page or opening a new tab displays it correctly.

Ref: https://issues.apache.org/jira/browse/FLINK-39494

It's a minor issue, but RocMarshal raised it to maintain UI consistency.

cc. @RocMarshal

@RocMarshal
Copy link
Copy Markdown
Contributor Author

Thanks @och5351 for the clarify.

Copy link
Copy Markdown
Contributor

@spuru9 spuru9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RocMarshal
Copy link
Copy Markdown
Contributor Author

Thanks all revolved in the PR, Merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants