[FLINK-36561][table] Fix ResultSet.wasNull() not reflecting per-column null values in JDBC driver#28219
Open
Au-Miner wants to merge 1 commit into
Open
[FLINK-36561][table] Fix ResultSet.wasNull() not reflecting per-column null values in JDBC driver#28219Au-Miner wants to merge 1 commit into
Au-Miner wants to merge 1 commit into
Conversation
…n null values in JDBC driver
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix
ResultSet.wasNull()in the Flink JDBC driver, which previously only tracked whether the whole row was null and so always returnedfalsefor individual null columns — violating the JDBC contract thatwasNull()must reflect the value most recently read.Brief change log
FlinkResultSet(getString,getBoolean,getByte,getShort,getInt,getLong,getFloat,getDouble,getBytes,getObject,getBigDecimal) to set thewasNullflag fromcurrentRow.isNullAt(...)(or the equivalent null check on the returned value) before returning. Label-based overloads andgetDate/getTime/getTimestampinherit the fix by delegation.Verifying this change
Added
FlinkResultSetTest#testWasNullReflectsPerColumnNullness, which reads a row of alternating null and non-null columns across BOOLEAN/TINYINT/SMALLINT/INT/BIGINT/FLOAT/DOUBLE/DECIMAL/STRING/BYTES/MAP and asserts thatwasNull()flips totrueafter each null read and back tofalseafter each non-null read.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation