[FLINK-38503] Adapt DefaultClusterClientServiceLoader to java 25#28250
Merged
Conversation
Collaborator
Contributor
Author
|
Thanks for taking a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The problem is that in jdk 25 there are bugs https://bugs.openjdk.org/browse/JDK-8350481 and https://bugs.openjdk.org/browse/JDK-8196182
which result into throwing
NoClassDefFoundErrorwhilehasNextforServideLoaderUnfortunately it was fixed only for jdk27. The PR is to adapt behavior of
DefaultClusterClientServiceLoaderfor java25Also I have java25 CI in my own Azure setup https://dev.azure.com/snuyanzin/flink/_build/results?buildId=4811&view=results where this fix is applied (together with some others which will come in other PRs). Before this change none of e2e was able to pass, now 2 passes, others are able to go further however still under investigation
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?