Skip to content

[FLINK-38503] Adapt DefaultClusterClientServiceLoader to java 25#28250

Merged
snuyanzin merged 1 commit into
apache:masterfrom
snuyanzin:flink38503
May 26, 2026
Merged

[FLINK-38503] Adapt DefaultClusterClientServiceLoader to java 25#28250
snuyanzin merged 1 commit into
apache:masterfrom
snuyanzin:flink38503

Conversation

@snuyanzin
Copy link
Copy Markdown
Contributor

@snuyanzin snuyanzin commented May 25, 2026

What is the purpose of the change

The problem is that in jdk 25 there are bugs https://bugs.openjdk.org/browse/JDK-8350481 and https://bugs.openjdk.org/browse/JDK-8196182
which result into throwing NoClassDefFoundError while hasNext for ServideLoader
Unfortunately it was fixed only for jdk27. The PR is to adapt behavior of DefaultClusterClientServiceLoader for java25

Also I have java25 CI in my own Azure setup https://dev.azure.com/snuyanzin/flink/_build/results?buildId=4811&view=results where this fix is applied (together with some others which will come in other PRs). Before this change none of e2e was able to pass, now 2 passes, others are able to go further however still under investigation

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 25, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@spuru9 spuru9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@rmetzger rmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snuyanzin
Copy link
Copy Markdown
Contributor Author

Thanks for taking a look

@snuyanzin snuyanzin merged commit 45295cf into apache:master May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants