Skip to content

[FLINK-39145][tests] Skip counters accumulation when state isn't initialized#28254

Merged
1996fanrui merged 1 commit into
apache:masterfrom
Efrat19:FLINK-39145-2
May 26, 2026
Merged

[FLINK-39145][tests] Skip counters accumulation when state isn't initialized#28254
1996fanrui merged 1 commit into
apache:masterfrom
Efrat19:FLINK-39145-2

Conversation

@Efrat19
Copy link
Copy Markdown
Contributor

@Efrat19 Efrat19 commented May 26, 2026

What is the purpose of the change

Sink task might be cancelled before state was initialized, should be handled as a valid scenario to avoid test failures due to null state.

Brief change log

  • Skip counters accumulation in VerifyingSinkBase#close when state isn't initialized to avoid test falkiness

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Was generative AI tooling used to co-author this PR?

no

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 26, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Efrat19 Efrat19 marked this pull request as draft May 26, 2026 08:02
@Efrat19 Efrat19 marked this pull request as ready for review May 26, 2026 10:01
@Efrat19
Copy link
Copy Markdown
Contributor Author

Efrat19 commented May 26, 2026

@flinkbot run azure

…ialized

Sink task might be cancelled before state was initialized, should be handled as a valid scenario to avoid test failures due to null state.
@Efrat19
Copy link
Copy Markdown
Contributor Author

Efrat19 commented May 26, 2026

@1996fanrui when you have time

Copy link
Copy Markdown
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, lgtm

@1996fanrui 1996fanrui merged commit 04a31ba into apache:master May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants