[FLINK-39790][state/metrics] Fix State latency/size tracking metrics not exported without sampling#28257
Open
Efrat19 wants to merge 1 commit into
Conversation
Collaborator
Contributor
Author
|
@flinkbot run azure |
588c12f to
e035d38
Compare
…not exported without sampling Previousely when set to state.*-track.keyed-state-enabled: true state.*-track.sample-interval: 1 metrics are not exported because for sampleInterval of 1, StateMetricBase#loopUpdateCounter will always return 0.
e035d38 to
7811eb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Previousely when set to
Metrics were not exported because for
sampleIntervalof 1,StateMetricBase#loopUpdateCounterwill always return 0.Brief change log
StateMetricBase#loopUpdateCounterto always return 1 ifsampleInterval= 1Verifying this change
This change added tests and can be verified as follows:
sampleInterval= 1Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
no