[FLINK-39773][tests] Use random ports in ClusterEntryPointTest#28265
Merged
Conversation
Collaborator
Contributor
Author
|
@gaborgsomogyi I noticed you were contributed here a couple of years ago |
gaborgsomogyi
approved these changes
May 27, 2026
Contributor
gaborgsomogyi
left a comment
There was a problem hiding this comment.
Assuming green with all JVM versions.
Contributor
Author
|
thanks for taking a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This test is failing in java25 since the ports are going to be free in async mode, in java 25 tests might started before ports are freed from previous test.
To make it more reliable: the PR makes using random ports
another way: making sure ports are freed before next test is started will require more changes
Brief change log
ClusterEntryPointTest
Verifying this change
the change is test itself
my CI with java25 where this test fails https://dev.azure.com/snuyanzin/flink/_build/results?buildId=4810&view=logs&j=7f652c99-c3cd-5aee-11e2-f8e88140dbea&t=d3173862-60e8-57db-ccd6-465075b97bea&l=8802
same ci with this fix (now the next test failed which will be fixed separately)
https://dev.azure.com/snuyanzin/flink/_build/results?buildId=4836&view=logs&j=9dc1b5dc-bcfa-5f83-eaa7-0cb181ddc267&t=e72e9469-7bd1-5a7c-cfdb-1df1c1c7d1dc&l=10544
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?