Skip to content

[FLINK-36602][tests] Add pre Calcite 1.38.0 tests for CALCITE-7562 issue#28272

Merged
snuyanzin merged 1 commit into
apache:masterfrom
snuyanzin:tests
May 29, 2026
Merged

[FLINK-36602][tests] Add pre Calcite 1.38.0 tests for CALCITE-7562 issue#28272
snuyanzin merged 1 commit into
apache:masterfrom
snuyanzin:tests

Conversation

@snuyanzin
Copy link
Copy Markdown
Contributor

What is the purpose of the change

The PR is a preparation PR before Calcite 1.38.0 upgrade
these tests still pass in with 1.37.0 and will fail with dummy 1.38.0 upgrade
Tests are made based on TPC DS queries

Brief change log

test

Verifying this change

The change is tests itself

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
  • The S3 file system connector: ( no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable )

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 28, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@liuyongvs liuyongvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label May 29, 2026
Copy link
Copy Markdown
Contributor

@raminqaf raminqaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@gustavodemorais gustavodemorais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

}

@Test
def testDateColumnInListWithStringLiterals(): Unit = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: if there are jira tickets for the issues that will come up with the upgrade, you could mention them here

Copy link
Copy Markdown
Contributor Author

@snuyanzin snuyanzin May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is already done within a separate PR
this PR is just extracted commit from 1.38.0 upgrade #28170

@snuyanzin
Copy link
Copy Markdown
Contributor Author

thanks for taking a look

@snuyanzin snuyanzin merged commit fa26789 into apache:master May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants