Skip to content

[FLINK-39125][table] Support injective casts from BINARY/VARBINARY to CHAR/VARCHAR for upsert keys#28480

Merged
gustavodemorais merged 1 commit into
apache:masterfrom
confluentinc:FLINK-39125
Jun 22, 2026
Merged

[FLINK-39125][table] Support injective casts from BINARY/VARBINARY to CHAR/VARCHAR for upsert keys#28480
gustavodemorais merged 1 commit into
apache:masterfrom
confluentinc:FLINK-39125

Conversation

@gustavodemorais

Copy link
Copy Markdown
Contributor

What is the purpose of the change

Recognize CAST from BINARY/VARBINARY to CHAR/VARCHAR as injective so that upsert keys are preserved through such projections. This unblocks upsert key tracking for byte-keyed columns cast to string, now that strict UTF-8 decoding is the default.

Brief change log

  • Add WHEN_CHAR_LENGTH_FITS_UTF8 injective rule for BINARY/VARBINARY to CHAR/VARCHAR in LogicalTypeCasts
  • Gate the injectivity in FlinkRelMdUniqueKeys on the legacy-bytes-to-string-cast config, since legacy U+FFFD substitution breaks uniqueness
  • Thread the input RelNode through getProjectUniqueKeys so the config is reachable

Verifying this change

  • LogicalTypeCastsTest
  • FlinkRelMdUpsertKeysTest
  • FlinkRelMdUniqueKeysTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

2.1.181 (Claude Code) with Opus 4.8

… CHAR/VARCHAR for upsert keys

Generated-by: Claude Code (Opus 4.8)
@gustavodemorais gustavodemorais changed the title [FLINK-39125][table] Support injective casts from BINARY/VARBINARY to… [FLINK-39125][table] Support injective casts from BINARY/VARBINARY to CHAR/VARCHAR for upsert keys Jun 18, 2026
@flinkbot

flinkbot commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@twalthr twalthr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gustavodemorais for completing the injective cast work with this PR. LGTM

@gustavodemorais gustavodemorais merged commit cce8840 into apache:master Jun 22, 2026
@gustavodemorais gustavodemorais deleted the FLINK-39125 branch June 22, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants