[FLINK-5247] Fix incorrect check in allowedLateness() method. Make it a no-op for non-event time windows.

[rohitagarwal003]

Also, fix outdated documentation.

[rohitagarwal003]

cc - @kl0u, @aljoscha for review

[rohitagarwal003]

Ping @aljoscha

[kl0u]

Hi @mindprince . Thanks for the work. The changes look good. My only comment is that in case of a processing time assigner, we should also log a warning that the allowed lateness is set to 0 (stating also the reason), instead of doing it silently. In general, I think that silently overriding user-specified parameters is not the best practice.

[rohitagarwal003]

Thanks for the review @kl0u

I didn't do it because there was no logger defined in the file.

[kl0u]

Hi @mindprince . What do you mean "in the file"? The allowed lateness can always be specified in the program by the developer, right? So logging a message is always a valid approach.

[xhumanoid]

I think @mindprince mean: at now logger not defined in class file

this classes without
private static final Logger LOG

[StephanEwen]

Thank you for fixing this.
I think it is good as it is, will merge this for Flink-1.2 and master...

[rohitagarwal003]

Merged in 87af841 and 4697b97