[FLINK-5395] [Build System] support locally build distribution by script create_release_files.sh #3049

shijinkui · 2016-12-27T15:53:28Z

create_release_files.sh is build flink release only. It's hard to build custom local Flink release distribution.
Let create_release_files.sh support:

custom git repo url
custom build special scala and hadoop version
add tools/flink to .gitignore
add usage

for example:

gen GPG key

gpg --gen-key

make local dist

NEW_VERSION=1.2.0 RELEASE_BRANCH=master OLD_VERSION=1.2-SNAPSHOT GPG_PASSPHRASE=shijinkui GPG_KEY=shijinkui IS_LOCAL_DIST=true GIT_REPO=github.com/apache/flink.git ./create_release_files.sh --scala-version 2.11 --hadoop-version 2.7.2

building local dist result

flink-1.2.0-bin-hadoop2x-scala_2.11
flink-1.2.0-bin-hadoop2x-scala_2.11.tgz
flink-1.2.0-bin-hadoop2x-scala_2.11.tgz.asc
flink-1.2.0-bin-hadoop2x-scala_2.11.tgz.md5
flink-1.2.0-bin-hadoop2x-scala_2.11.tgz.sha
flink-1.2.0-src.tgz
flink-1.2.0-src.tgz.asc
flink-1.2.0-src.tgz.md5
flink-1.2.0-src.tgz.sha

General
- The pull request references the related JIRA issue ("[FLINK-5395] support locally build distribution by script create_release_files.sh")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
Tests & Build
- Functionality added by the pull request is covered by tests
- mvn clean verify has been executed successfully locally or a Travis build has passed

StephanEwen · 2017-01-05T19:34:55Z

Thank you for this contribution. Looks good at a first glance.

Would be good if @uce or @rmetzger could take a look, they worked mostly with the release script.

uce

The changes look good judging from the code. I had some minor inline comments.

Before merging this, we would definitely have to run the script as well. I did not do this and hence I would wait with merging this.

Maybe @rmetzger can try out the updated script as he is 1.2 release manager?

uce · 2017-01-09T17:26:36Z

tools/create_release_files.sh

-
+IS_LOCAL_DIST=${IS_LOCAL_DIST:-false}
+GIT_REPO=${GIT_REPO:-git-wip-us.apache.org/repos/asf/flink.git}
+scalaV=none


Should we rename this to SCALA_VERSION and HADOOP_VERSION in order to follow the style of the other variables?

That' fine.

uce · 2017-01-09T17:28:27Z

tools/create_release_files.sh

+      git checkout master
+      git branch -D $target_branch -f
+    } || {
+      echo "branch $target_branch maybe not found"


I think the error message should just be branch $target_branch not found without the maybe.

uce · 2017-01-09T17:32:13Z

tools/create_release_files.sh

+  make_binary_release "hadoop24" "-Dhadoop.version=2.4.1" 2.11
+  make_binary_release "hadoop26" "-Dhadoop.version=2.6.3" 2.11
+  make_binary_release "hadoop27" "-Dhadoop.version=2.7.2" 2.11
+elif [ "$scalaV" == none ] && [ "$hadoopV" != "none" ]


Can we add the "..." for all strings to have it consistent?

…ipt create_release_files.sh

shijinkui · 2017-01-11T09:44:52Z

Before merging this, we would definitely have to run the script as well. I did not do this and hence I would wait with merging this.

@uce @rmetzger I use this script build local distribution successfully. But the apache release have not try.

rmetzger · 2017-01-23T15:35:24Z

+1 is good to merge.

I'll test it as part of the RC1 for 1.2.0 creation

…ipt create_release_files.sh This closes apache#3049

…ipt create_release_files.sh This closes #3049

rmetzger · 2017-01-24T13:02:30Z

tools/create_release_files.sh

-  RELEASE_HASH=`git rev-parse HEAD`
-  echo "Echo created release hash $RELEASE_HASH"
+  # local dist have no need to commit to remote
+  if [ ! IS_LOCAL_DIST ]; then


(Note to myself: This doesn't work)

rmetzger · 2017-01-24T13:02:46Z

tools/create_release_files.sh

+  make_binary_release "hadoop2x" "-Dhadoop.version=$HADOOP_VERSION" "$SCALA_VERSION"
+fi

+if [ ! IS_LOCAL_DIST ] ; then


this as well

rmetzger · 2017-01-24T14:15:33Z

I fixed the mentioned issues in http://git-wip-us.apache.org/repos/asf/flink/commit/5f0d8c9d

shijinkui · 2017-01-24T14:21:51Z

OK

…ipt create_release_files.sh This closes apache#3049

uce reviewed Jan 9, 2017

View reviewed changes

[FLINK-5395] [Build System] support locally build distribution by scr…

2130246

…ipt create_release_files.sh

shijinkui force-pushed the FLINK-5395 branch from 5c1bdb3 to 2130246 Compare January 11, 2017 09:43

rmetzger pushed a commit to rmetzger/flink that referenced this pull request Jan 23, 2017

[FLINK-5395] [Build System] support locally build distribution by scr…

90a54d1

…ipt create_release_files.sh This closes apache#3049

asfgit pushed a commit that referenced this pull request Jan 24, 2017

[FLINK-5395] [Build System] support locally build distribution by scr…

2e175fb

…ipt create_release_files.sh This closes #3049

asfgit closed this in 6b55e2c Jan 24, 2017

rmetzger reviewed Jan 24, 2017

View reviewed changes

joseprupi pushed a commit to joseprupi/flink that referenced this pull request Feb 12, 2017

[FLINK-5395] [Build System] support locally build distribution by scr…

903806b

…ipt create_release_files.sh This closes apache#3049

rmetzger added the component=BuildSystem label Mar 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-5395] [Build System] support locally build distribution by script create_release_files.sh #3049

[FLINK-5395] [Build System] support locally build distribution by script create_release_files.sh #3049

Uh oh!

shijinkui commented Dec 27, 2016 •

edited

Loading

Uh oh!

StephanEwen commented Jan 5, 2017

Uh oh!

uce left a comment

Uh oh!

uce Jan 9, 2017

Uh oh!

shijinkui Jan 10, 2017

Uh oh!

uce Jan 9, 2017

Uh oh!

uce Jan 9, 2017

Uh oh!

shijinkui commented Jan 11, 2017 •

edited

Loading

Uh oh!

rmetzger commented Jan 23, 2017

Uh oh!

rmetzger Jan 24, 2017

Uh oh!

rmetzger Jan 24, 2017

Uh oh!

rmetzger commented Jan 24, 2017

Uh oh!

shijinkui commented Jan 24, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[FLINK-5395] [Build System] support locally build distribution by script create_release_files.sh #3049

[FLINK-5395] [Build System] support locally build distribution by script create_release_files.sh #3049

Uh oh!

Conversation

shijinkui commented Dec 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StephanEwen commented Jan 5, 2017

Uh oh!

uce left a comment

Choose a reason for hiding this comment

Uh oh!

uce Jan 9, 2017

Choose a reason for hiding this comment

Uh oh!

shijinkui Jan 10, 2017

Choose a reason for hiding this comment

Uh oh!

uce Jan 9, 2017

Choose a reason for hiding this comment

Uh oh!

uce Jan 9, 2017

Choose a reason for hiding this comment

Uh oh!

shijinkui commented Jan 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rmetzger commented Jan 23, 2017

Uh oh!

rmetzger Jan 24, 2017

Choose a reason for hiding this comment

Uh oh!

rmetzger Jan 24, 2017

Choose a reason for hiding this comment

Uh oh!

rmetzger commented Jan 24, 2017

Uh oh!

shijinkui commented Jan 24, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shijinkui commented Dec 27, 2016 •

edited

Loading

shijinkui commented Jan 11, 2017 •

edited

Loading