[Flink 5404] Consolidate and update S3 documentation#3054
[Flink 5404] Consolidate and update S3 documentation#3054medale wants to merge 4 commits intoapache:masterfrom medale:FLINK-5404
Conversation
|
Error about RocksDB caused by: java.lang.UnsatisfiedLinkError: Native Library /tmp/librocksdbjni-linux64.so already loaded in another classloader at java.lang.ClassLoader.loadLibrary1(ClassLoader.java:1931). Since I only changed documentation this seems like an unrelated error with the overall build. How do I continue or re-run? |
docs/dev/batch/connectors.md
Outdated
| - the `flink-conf.yaml` has set the `fs.hdfs.hadoopconf` property set to the Hadoop configuration directory. | ||
| - the Hadoop configuration (in that directory) has an entry for the required file system. Examples for S3 and Alluxio are shown below. | ||
| - the required classes for using the file system are available in the `lib/` folder of the Flink installation (on all machines running Flink). If putting the files into the directory is not possible, Flink is also respecting the `HADOOP_CLASSPATH` environment variable to add Hadoop jar files to the classpath. | ||
| - the `flink-conf.yaml` has set the `fs.hdfs.hadoopconf` property to the Hadoop configuration directory. For automated testing or running from an IDE the directory containing `flink-conf.yaml` can be set by defining the FLINK_CONF_DIR environment variable. |
There was a problem hiding this comment.
Add ` around FLINK_CONF_DIR ==> FLINK_CONF_DIR
docs/setup/aws.md
Outdated
| ``` | ||
|
|
||
| This registers `path/to/etc/hadoop` as Hadoop's configuration directory with Flink. | ||
| This registers `/path/to/etc/hadoop` as Hadoop's configuration directory with Flink. Flink will look for the "core-site.xml" and "hdfs-site.xml" files in the specified directory. |
There was a problem hiding this comment.
Reference to core-site.xml and hdfs-site.xml here uses double apostrophes, while ` is used in other places.
Lets keep that styling consistent here :)
|
@medale The test failure is unrelated, it's ok to ignore them. The tests will also re-run once Travis detects more commits are pushed to the branch. |
|
@tzulitai thank you for the feedback and catching those stylistic elements! I made the changes and recommitted. |
|
Thanks for the PR. Looks good to me. Merging this... |
3 participants
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.
General
Documentation
Tests & Build
mvn clean verifyhas been executed successfully locally or a Travis build has passed