-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-5417][DOCUMENTATION]correct the wrong config file name #3071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I use Illustrator to edit svg file, which will add some header infos that cause CI failed. Is there any prefered svg editor? |
|
you should be able to open the svg file with any text editor and add the license manually. |
|
I will take a look at these changes. Just a small note: We are not getting notified of pushed changes, a small comment is always good to get attention ;) |
|
When viewing the documentation in firefox there is now a lot of whitespace above the diagram. The dimensions have slightly changed as well :/ |
|
Hi @zentol , I've updated the svg using Inkscape. |
|
well that's the thing, i did rebuild the documentation and in the new version the whitespace was shown. The old version didn't have that. I'll try the updated version and will make screenshots if i see it again ;) |
|
Nice, the updated version is better :) |
|
I guess it is probably that the illustrator added sth. |
|
Could be; it's a bit frightening to see how much the results differ based on which application one uses :/ Anyway, I will add this to my batch of commits to merge. However, the massive diff drove me crazy, so I massaged the svg file a bit and the diff is now a bit smaller (see here: zentol@4c8d2bd). Hope you don't mind that. |
|
Surely not :) |
As the config file name is conf/flink-conf.yaml, the usage "conf/flink-config.yaml" in document is wrong and easy to confuse user. We should correct them.