Skip to content

Conversation

@WangTaoTheTonic
Copy link
Contributor

As the config file name is conf/flink-conf.yaml, the usage "conf/flink-config.yaml" in document is wrong and easy to confuse user. We should correct them.

@WangTaoTheTonic
Copy link
Contributor Author

I use Illustrator‎ to edit svg file, which will add some header infos that cause CI failed. Is there any prefered svg editor?

@zentol
Copy link
Contributor

zentol commented Jan 6, 2017

you should be able to open the svg file with any text editor and add the license manually.

@zentol
Copy link
Contributor

zentol commented Jan 12, 2017

I will take a look at these changes.

Just a small note: We are not getting notified of pushed changes, a small comment is always good to get attention ;)

@zentol
Copy link
Contributor

zentol commented Jan 12, 2017

When viewing the documentation in firefox there is now a lot of whitespace above the diagram. The dimensions have slightly changed as well :/

@WangTaoTheTonic
Copy link
Contributor Author

Hi @zentol , I've updated the svg using Inkscape.
Is the whitespace you refer to on the topest(the red highlighted part)? I think it's normal as the original one has them to. It would not affect view in documents.
default

@zentol
Copy link
Contributor

zentol commented Jan 16, 2017

well that's the thing, i did rebuild the documentation and in the new version the whitespace was shown. The old version didn't have that. I'll try the updated version and will make screenshots if i see it again ;)

@zentol
Copy link
Contributor

zentol commented Jan 16, 2017

Nice, the updated version is better :)

@WangTaoTheTonic
Copy link
Contributor Author

I guess it is probably that the illustrator added sth.

@zentol
Copy link
Contributor

zentol commented Jan 16, 2017

Could be; it's a bit frightening to see how much the results differ based on which application one uses :/

Anyway, I will add this to my batch of commits to merge. However, the massive diff drove me crazy, so I massaged the svg file a bit and the diff is now a bit smaller (see here: zentol@4c8d2bd). Hope you don't mind that.

@WangTaoTheTonic
Copy link
Contributor Author

Surely not :)

zentol pushed a commit to zentol/flink that referenced this pull request Jan 17, 2017
zentol pushed a commit to zentol/flink that referenced this pull request Jan 17, 2017
zentol pushed a commit to zentol/flink that referenced this pull request Jan 17, 2017
zentol pushed a commit to zentol/flink that referenced this pull request Jan 19, 2017
zentol pushed a commit to zentol/flink that referenced this pull request Jan 19, 2017
@asfgit asfgit closed this in 6c03491 Jan 20, 2017
joseprupi pushed a commit to joseprupi/flink that referenced this pull request Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants