-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-5296] Expose the old AlignedWindowOperators through special as… #3075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
...in/java/org/apache/flink/streaming/api/windowing/assigners/BaseAlignedWindowAssigner.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.flink.streaming.api.windowing.assigners; | ||
|
|
||
| import org.apache.flink.api.common.ExecutionConfig; | ||
| import org.apache.flink.api.common.typeutils.TypeSerializer; | ||
| import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; | ||
| import org.apache.flink.streaming.api.windowing.triggers.Trigger; | ||
| import org.apache.flink.streaming.api.windowing.windows.TimeWindow; | ||
|
|
||
| import java.util.Collection; | ||
|
|
||
| /** | ||
| * A base {@link WindowAssigner} used to instantiate one of the deprecated | ||
| * {@link org.apache.flink.streaming.runtime.operators.windowing.AccumulatingProcessingTimeWindowOperator | ||
| * AccumulatingProcessingTimeWindowOperator} and | ||
| * {@link org.apache.flink.streaming.runtime.operators.windowing.AggregatingProcessingTimeWindowOperator | ||
| * AggregatingProcessingTimeWindowOperator}. | ||
| * <p><p> | ||
| * For assigner that extend this one, the user can check the {@link TumblingAlignedProcessingTimeWindows} | ||
| * and the {@link SlidingAlignedProcessingTimeWindows}. | ||
| * */ | ||
| public class BaseAlignedWindowAssigner extends WindowAssigner<Object, TimeWindow> { | ||
|
|
||
| private static final long serialVersionUID = -6214980179706960234L; | ||
|
|
||
| private final long size; | ||
|
|
||
| protected BaseAlignedWindowAssigner(long size) { | ||
| this.size = size; | ||
| } | ||
|
|
||
| public long getSize() { | ||
| return size; | ||
| } | ||
|
|
||
| @Override | ||
| public Collection<TimeWindow> assignWindows(Object element, long timestamp, WindowAssignerContext context) { | ||
| throw new UnsupportedOperationException("This assigner should not be used with the WindowOperator."); | ||
| } | ||
|
|
||
| @Override | ||
| public Trigger<Object, TimeWindow> getDefaultTrigger(StreamExecutionEnvironment env) { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public TypeSerializer<TimeWindow> getWindowSerializer(ExecutionConfig executionConfig) { | ||
| throw new UnsupportedOperationException("This assigner should not be used with the WindowOperator."); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isEventTime() { | ||
| throw new UnsupportedOperationException("This assigner should not be used with the WindowOperator."); | ||
| } | ||
| } |
61 changes: 61 additions & 0 deletions
61
...g/apache/flink/streaming/api/windowing/assigners/SlidingAlignedProcessingTimeWindows.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.streaming.api.windowing.assigners; | ||
|
|
||
| import org.apache.flink.streaming.api.windowing.time.Time; | ||
|
|
||
| /** | ||
| * A processing time sliding {@link WindowAssigner window assigner} used to perform windowing using the | ||
| * {@link org.apache.flink.streaming.runtime.operators.windowing.AccumulatingProcessingTimeWindowOperator | ||
| * AccumulatingProcessingTimeWindowOperator} and the | ||
| * {@link org.apache.flink.streaming.runtime.operators.windowing.AggregatingProcessingTimeWindowOperator | ||
| * AggregatingProcessingTimeWindowOperator}. | ||
| * <p><p> | ||
| * With this assigner, the {@code trigger} used is a | ||
| * {@link org.apache.flink.streaming.api.windowing.triggers.ProcessingTimeTrigger | ||
| * ProcessingTimeTrigger} and no {@code evictor} can be specified. | ||
| * <p><p> | ||
| * <b>WARNING:</b> Bear in mind that no rescaling and no backwards compatibility is supported. | ||
| * */ | ||
| public class SlidingAlignedProcessingTimeWindows extends BaseAlignedWindowAssigner { | ||
|
|
||
| private static final long serialVersionUID = 3695562702662473688L; | ||
|
|
||
| private final long slide; | ||
|
|
||
| public SlidingAlignedProcessingTimeWindows(long size, long slide) { | ||
| super(size); | ||
| this.slide = slide; | ||
| } | ||
|
|
||
| public long getSlide() { | ||
| return slide; | ||
| } | ||
|
|
||
| /** | ||
| * Creates a new {@code SlidingAlignedProcessingTimeWindows} {@link WindowAssigner} that assigns | ||
| * elements to sliding time windows based on the element timestamp. | ||
| * | ||
| * @param size The size of the generated windows. | ||
| * @param slide The slide interval of the generated windows. | ||
| */ | ||
| public static SlidingAlignedProcessingTimeWindows of(Time size, Time slide) { | ||
| return new SlidingAlignedProcessingTimeWindows(size.toMilliseconds(), slide.toMilliseconds()); | ||
| } | ||
| } |
53 changes: 53 additions & 0 deletions
53
.../apache/flink/streaming/api/windowing/assigners/TumblingAlignedProcessingTimeWindows.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.streaming.api.windowing.assigners; | ||
|
|
||
| import org.apache.flink.streaming.api.windowing.time.Time; | ||
|
|
||
| /** | ||
| * A processing time tumbling {@link WindowAssigner window assigner} used to perform windowing using the | ||
| * {@link org.apache.flink.streaming.runtime.operators.windowing.AccumulatingProcessingTimeWindowOperator | ||
| * AccumulatingProcessingTimeWindowOperator} and the | ||
| * {@link org.apache.flink.streaming.runtime.operators.windowing.AggregatingProcessingTimeWindowOperator | ||
| * AggregatingProcessingTimeWindowOperator}. | ||
| * <p><p> | ||
| * With this assigner, the {@code trigger} used is a | ||
| * {@link org.apache.flink.streaming.api.windowing.triggers.ProcessingTimeTrigger | ||
| * ProcessingTimeTrigger} and no {@code evictor} can be specified. | ||
| * <p><p> | ||
| * <b>WARNING:</b> Bear in mind that no rescaling and no backwards compatibility is supported. | ||
| * */ | ||
| public class TumblingAlignedProcessingTimeWindows extends BaseAlignedWindowAssigner { | ||
|
|
||
| private static final long serialVersionUID = -6217477609512299842L; | ||
|
|
||
| protected TumblingAlignedProcessingTimeWindows(long size) { | ||
| super(size); | ||
| } | ||
|
|
||
| /** | ||
| * Creates a new {@code TumblingAlignedProcessingTimeWindows} {@link WindowAssigner} that assigns | ||
| * elements to time windows based on the element timestamp. | ||
| * | ||
| * @param size The size of the generated windows. | ||
| */ | ||
| public static TumblingAlignedProcessingTimeWindows of(Time size) { | ||
| return new TumblingAlignedProcessingTimeWindows(size.toMilliseconds()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is simply a copy of the old code, right?