-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-5442] Ensure order of enum elements in StateDescriptor.Type #3091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-5442] Ensure order of enum elements in StateDescriptor.Type #3091
Conversation
|
cc @StephanEwen |
|
Looks good, but is that not breaking it now, by changing the order? I would almost suggest to not reorder now - it appears users have jumped onto the RC0 already and this is not really a crucial fix (more a code beautification) |
|
It only breaks w.r.t. to the previous dev master branch, right? I just preferred to have UNKNOWN at position 0 because the future way of adding enum entries is basically "append only" and having this special state in the middle then would look weird. |
|
When was that enum introduced? Can we get a feeling how many people are already using this? |
|
It was introduced by middle/end of december 16. The benefit is also just for esthetic reasons. Would you like me to restore the old order? |
|
If it is in so shortly, lets make it clean and keep the new order... |
|
Merging this... |
…ptor.Type through a test This closes apache#3091
…ptor.Type through a test This closes apache#3091
…ptor.Type through a test This closes apache#3091
…ptor.Type through a test This closes apache#3091
…ptor.Type through a test This closes apache#3091
This PR adds a test to ensure the order of elements in enum
StateDescriptor.Typewhich is important for the serialization format.