[FLINK-5681] Make ReaperThread for SafetyNetCloseableRegistry a singleton #3230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itableThreadLocal
StefanRRichter
force-pushed
the
safetyNetSingletonReaperThread
branch
from
ec968c2 to
4645bf1
Compare
StefanRRichter
force-pushed
the
safetyNetSingletonReaperThread
branch
from
25325ec to
3b6cad4
Compare
Contributor
|
Quick question about this change: The reaper thread now does not remove the closeables any more from the |
StefanRRichter
commented
Jan 29, 2017
| @Override | ||
| public void close() throws IOException { | ||
| synchronized (closeableRegistry.getSynchronizationLock()) { | ||
| closeableRegistry.closeableToRef.remove(innerCloseable); |
Contributor
Author
There was a problem hiding this comment.
Removal is done here now, because the reaper thread should not keep/locate right references for all registries
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Jan 30, 2017
…ry a singleton This closes apache#3230
GEOFBOT
pushed a commit
to GEOFBOT/flink
that referenced
this pull request
Feb 3, 2017
…ry a singleton This closes apache#3230
joseprupi
pushed a commit
to joseprupi/flink
that referenced
this pull request
Feb 12, 2017
…ry a singleton This closes apache#3230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each
SafetyNetCloseableRegistryspawns an own ReaperThread. However, this duty could also be fulfilled by a single ReaperThread that is shared by all registries to save unnecessary threads.This PR makes the reaper thread a singleton, because we could potentially create more registries now and it is not required to have one reaper thread per registry.
PR sits on top or #3229 .