Skip to content

[FLINK-5863][queryable state] Add the serialization of list states in KvStateRequestSerializer#3387

Closed
shixiaogang wants to merge 1 commit intoapache:masterfrom
alibaba:flink-5863
Closed

[FLINK-5863][queryable state] Add the serialization of list states in KvStateRequestSerializer#3387
shixiaogang wants to merge 1 commit intoapache:masterfrom
alibaba:flink-5863

Conversation

@shixiaogang
Copy link
Copy Markdown

  1. Add serializeList() in KvStateRequestSerialization
  2. Modify the unit tests of KvStateRequestSerialization, without the access to protected methods.
  3. Move KvStateRequestSerializationRocksDBTest from package org.apache.flink.test.query to org.apache.flink.contrib.streaming.state.

@uce
Copy link
Copy Markdown
Contributor

uce commented Feb 22, 2017

If I understand this correctly, this gets rid of duplicated code. I think this is in general very valuable, but the problem is queryable state right now is that we need to refactor this for 1.3 anyways. Currently, too many flink-runtime components are exposed to the user. I'm working on a FLIP to improve the user APIs for 1.3 and deprecated (or maybe even remove) the current APIs. This will therefore become obsolete. What do you think? Should we close this PR and issue and you help on the proposed changes instead?

@shixiaogang
Copy link
Copy Markdown
Author

The PR is just some cleaning of the code. Now that we are planning to refactor the implementation, I agree to close the PR and I am very willing to contribute to the FLIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants