[FLINK-5863][queryable state] Add the serialization of list states in KvStateRequestSerializer#3387
Closed
shixiaogang wants to merge 1 commit intoapache:masterfrom
Closed
[FLINK-5863][queryable state] Add the serialization of list states in KvStateRequestSerializer#3387shixiaogang wants to merge 1 commit intoapache:masterfrom
shixiaogang wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
If I understand this correctly, this gets rid of duplicated code. I think this is in general very valuable, but the problem is queryable state right now is that we need to refactor this for 1.3 anyways. Currently, too many |
Author
|
The PR is just some cleaning of the code. Now that we are planning to refactor the implementation, I agree to close the PR and I am very willing to contribute to the FLIP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serializeList()inKvStateRequestSerializationKvStateRequestSerialization, without the access to protected methods.KvStateRequestSerializationRocksDBTestfrom packageorg.apache.flink.test.querytoorg.apache.flink.contrib.streaming.state.