[FLINK-5928] [checkpoints] Use custom metadata file for externalized checkpoints #3424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… strictly on FileSystems That is the first step towards checkpoints that can be externalized to other stores as well, like k/v stores and databases, if supported by the state backend.
…r aware of the root state backend
…pointsTest Problem: there were only unit tests for the checkpoint instances available that don't test the behaviour of the checkpoint coordinator with respect to externalized checkpoints.
Contributor
|
Thanks, good and critical fix! |
Contributor
|
Looks good, merging this... |
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Feb 28, 2017
…pointsTest Problem: there were only unit tests for the checkpoint instances available that don't test the behaviour of the checkpoint coordinator with respect to externalized checkpoints. This closes apache#3424
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Feb 28, 2017
…pointsTest Problem: there were only unit tests for the checkpoint instances available that don't test the behaviour of the checkpoint coordinator with respect to externalized checkpoints. This closes apache#3424
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Feb 28, 2017
…pointsTest Problem: there were only unit tests for the checkpoint instances available that don't test the behaviour of the checkpoint coordinator with respect to externalized checkpoints. This closes apache#3424
p16i
pushed a commit
to p16i/flink
that referenced
this pull request
Apr 16, 2017
…pointsTest Problem: there were only unit tests for the checkpoint instances available that don't test the behaviour of the checkpoint coordinator with respect to externalized checkpoints. This closes apache#3424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_metadatabut a randomcheckpoint_metadata-:randomSuffixfile for externalized checkpoints, because they are not unique per configured directory. Hopefully, we can get rid of this soon with @StephanEwen's refactorings.This is based on top of #3411, which is already good to merge.