[FLINK-6007] Allow key removal from within the watermark callback.#3514
Closed
kl0u wants to merge 1 commit intoapache:masterfrom
Closed
[FLINK-6007] Allow key removal from within the watermark callback.#3514kl0u wants to merge 1 commit intoapache:masterfrom
kl0u wants to merge 1 commit intoapache:masterfrom
Conversation
aljoscha
approved these changes
Mar 13, 2017
Contributor
aljoscha
left a comment
aljoscha
left a comment
There was a problem hiding this comment.
This looks good! 👍
Please go ahead and merge.
| /** | ||
| * An array of sets of keys keeping the keys "to delete" split | ||
| * by the key-group they belong to. Each key-group has one set. | ||
| * <p> |
Contributor
There was a problem hiding this comment.
IMHO, the formatting on paragraphs should be:
Some text bla bla black
<p>Other Text sdfasfaf
on the other hand, we don't have a style guide on that and no checkstyle for checking it .... 😉
kl0u
force-pushed
the
watermark-callback-fix
branch
from
d3a1b6e to
e54fc3b
Compare
Contributor
Author
|
Thanks for the review @aljoscha . Waiting for travis and then merging. |
When deleting a key from the InternalWatermarkCallbackService, the deleted key is put into a separate set, and the actual deletion happens after the iteration over all keys has finished. To avoid checkpointing the deletion set, the actual cleanup also happens upon checkpointing.
kl0u
force-pushed
the
watermark-callback-fix
branch
from
e54fc3b to
14c1941
Compare
Contributor
Author
|
Merged at 14c1941 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting a key from the
InternalWatermarkCallbackService, the deleted key is put into a separate set, and the actual deletion happens after the iteration over all keys has finished. To avoidcheckpointing the deletion set, the actual cleanup also happens upon checkpointing.
R @aljoscha