New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-6007] Allow key removal from within the watermark callback. #3514

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@kl0u
Contributor

kl0u commented Mar 10, 2017

When deleting a key from the InternalWatermarkCallbackService, the deleted key is put into a separate set, and the actual deletion happens after the iteration over all keys has finished. To avoid
checkpointing the deletion set, the actual cleanup also happens upon checkpointing.

R @aljoscha

@aljoscha

This looks good! 👍

Please go ahead and merge.

@kl0u

This comment has been minimized.

Show comment
Hide comment
@kl0u

kl0u Mar 13, 2017

Contributor

Thanks for the review @aljoscha . Waiting for travis and then merging.

Contributor

kl0u commented Mar 13, 2017

Thanks for the review @aljoscha . Waiting for travis and then merging.

[FLINK-6007] Allow key removal from within the watermark callback.
When deleting a key from the InternalWatermarkCallbackService, the
deleted key is put into a separate set, and the actual deletion
happens after the iteration over all keys has finished. To avoid
checkpointing the deletion set, the actual cleanup also happens
upon checkpointing.
@kl0u

This comment has been minimized.

Show comment
Hide comment
@kl0u

kl0u Mar 13, 2017

Contributor

Merged at 14c1941

Contributor

kl0u commented Mar 13, 2017

Merged at 14c1941

@kl0u kl0u closed this Mar 13, 2017

@kl0u kl0u deleted the kl0u:watermark-callback-fix branch Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment