Skip to content

Conversation

@aljoscha
Copy link
Contributor

@aljoscha aljoscha commented Feb 2, 2015

Kryo already supports them, so it was just a question of the
TypeExtractor allowing them.

I also added tests for this.

@StephanEwen
Copy link
Contributor

Looks good to me so far, modulo two comments:

  • Since the type extractor code is changed a lot, it would be good to have a test validating that the TypeExtractor allows abstract types and interfaces.
  • I would change the log level of the messages (abstract types are less performant, type is no POJO) to INFO, since WARN implies to me that something is wrong (which is not)

@aljoscha
Copy link
Contributor Author

aljoscha commented Feb 3, 2015

But I extended the test with a SerializerTest for both Interfaces (traits) and abstract classes. The other thing I will change, yes.

@StephanEwen
Copy link
Contributor

The tests cover that the serializer supports this. One issue was that the type extractor rejected the types, even though they were supported.

@aljoscha
Copy link
Contributor Author

aljoscha commented Feb 3, 2015

You're right.

@aljoscha aljoscha force-pushed the interfaces-generic-type-info-fix branch from 6b17331 to 59e6ff3 Compare February 5, 2015 09:56
Kryo already supports them, so it was just a question of the
TypeExtractor allowing them.
@aljoscha aljoscha force-pushed the interfaces-generic-type-info-fix branch from 59e6ff3 to ecf3e08 Compare February 5, 2015 09:59
@aljoscha aljoscha closed this Feb 5, 2015
@aljoscha aljoscha deleted the interfaces-generic-type-info-fix branch February 5, 2015 11:03
@pushpendra-jaiswal-90
Copy link

Hi @aljoscha
Still getting this warning on compiling for accessing a of type Map[String,Any]
Type Any has no fields that are visible from Scala Type analysis. Falling back to Java Type Analysis (TypeExtractor).

Flink version 1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants