[FLINK-6124] [table] Add min/max string aggregation with retracion #3593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shaoxuan-wang
left a comment
shaoxuan-wang
left a comment
There was a problem hiding this comment.
LGTM. Can you please consider adding test cases in Max/MinWithRetractAggFunctionTest
| * Built-in String Max with retraction aggregate function | ||
| */ | ||
| class StringMaxWithRetractAggFunction extends MaxWithRetractAggFunction[String] { | ||
| override def getInitValue: String = "" |
| * Built-in String Min with retraction aggregate function | ||
| */ | ||
| class StringMinWithRetractAggFunction extends MinWithRetractAggFunction[String] { | ||
| override def getInitValue: String = "" |
Contributor
Author
|
Thanks for the hint @shaoxuan-wang. I added the tests and will merge this. |
p16i
pushed a commit
to p16i/flink
that referenced
this pull request
Apr 16, 2017
hequn8128
pushed a commit
to hequn8128/flink
that referenced
this pull request
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing retraction aggregations for strings.