[FLINK-6217] ContaineredTaskManagerParameters sets off-heap memory size incorrectly #3648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The failed tests are being addressed in FLINK-6175. |
Author
|
The test failure seems unrelated. Cannot reproduce locally. |
Contributor
|
Good fix, thanks @haohui I was wondering - I am a trying to advocate fewer dependencies in Flink (there is always the problem of shading and conflicts) so if there is a way to do this without Guava, that'd be great. I think |
Author
|
Totally Agree :-) @StephanEwen please take another look. |
Contributor
|
+1 to merge this |
tillrohrmann
pushed a commit
to tillrohrmann/flink
that referenced
this pull request
May 3, 2017
…ze incorrectly. This closes apache#3648.
Contributor
|
Thanks for your contribution @haohui and the review @StephanEwen. Changes look good to me. Merging this PR. |
tillrohrmann
pushed a commit
to tillrohrmann/flink
that referenced
this pull request
May 5, 2017
…ze incorrectly. This closes apache#3648.
fanyon
pushed a commit
to fanyon/flink
that referenced
this pull request
May 15, 2017
…ze incorrectly. This closes apache#3648.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.